[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles #145477

cjgillot · 2025-08-16T00:04:12Z

cjgillot · 2025-08-16T00:05:55Z

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rust-bors · 2025-08-16T02:19:21Z

☀️ Try build successful (CI)
Build commit: 34dd67f (34dd67f42f0f2050c773b332e2dd333618c22743, parent: cd7cbe818e4a66d46fe2df993d1b8518eba8a5cd)

rust-timer · 2025-08-16T07:24:00Z

Finished benchmarking commit (34dd67f): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 3.3%]	58
Regressions ❌ (secondary)	1.8%	[0.0%, 19.4%]	58
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.0%]	4
All ❌✅ (primary)	0.5%	[0.2%, 3.3%]	58

Max RSS (memory usage)

Results (primary 1.4%, secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.5%, 7.3%]	17
Regressions ❌ (secondary)	5.4%	[1.2%, 12.3%]	6
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.3%]	2
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	1.4%	[-1.4%, 7.3%]	19

Cycles

Results (primary 2.9%, secondary 4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	5.3%	[2.1%, 12.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

Results (primary 0.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 0.6%]	2
Regressions ❌ (secondary)	0.3%	[0.1%, 0.4%]	3
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-1.8%	[-7.1%, -0.1%]	5
All ❌✅ (primary)	0.1%	[-0.0%, 0.6%]	5

Bootstrap: 469.562s -> 472.464s (0.62%)
Artifact size: 377.55 MiB -> 377.67 MiB (0.03%)

cjgillot · 2025-08-16T14:48:02Z

@bors try @rust-timer queue

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rust-bors · 2025-08-16T17:07:25Z

☀️ Try build successful (CI)
Build commit: 4e9488c (4e9488c147d4057600076145eccb670b130147d5, parent: 2e2642e641a941f0a1400c7827fd89aa86fef8f4)

rust-timer · 2025-08-16T18:40:34Z

Finished benchmarking commit (4e9488c): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.9%]	23
Regressions ❌ (secondary)	1.5%	[0.1%, 9.7%]	59
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	0.4%	[-1.6%, 0.9%]	24

Max RSS (memory usage)

Results (primary 1.7%, secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.5%, 7.5%]	19
Regressions ❌ (secondary)	6.6%	[0.4%, 12.9%]	5
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	1.7%	[-1.3%, 7.5%]	20

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[2.1%, 10.2%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.8%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.2%	[0.1%, 0.4%]	4
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-2.9%	[-6.8%, -0.0%]	3
All ❌✅ (primary)	0.0%	[-0.0%, 0.1%]	4

Bootstrap: 470.222s -> 472.094s (0.40%)
Artifact size: 377.51 MiB -> 377.42 MiB (-0.02%)

bors · 2025-08-23T06:22:24Z

☔ The latest upstream changes (presumably #145469) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-08-24T15:43:02Z

☔ The latest upstream changes (presumably #145384) made this pull request unmergeable. Please resolve the merge conflicts.

rust-log-analyzer · 2025-09-18T02:15:32Z

The job x86_64-gnu-llvm-20 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/print_type_sizes/coroutine_discr_placement.rs stdout ----
Saved the actual stdout to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/coroutine_discr_placement/coroutine_discr_placement.stdout`
diff of stdout:

- print-type-size type: `std::pin::Pin<&mut {coroutine@$DIR/coroutine_discr_placement.rs:13:5: 13:7}>`: 8 bytes, alignment: 8 bytes
- print-type-size     field `.pointer`: 8 bytes
3 print-type-size type: `{coroutine@$DIR/coroutine_discr_placement.rs:13:5: 13:7}`: 8 bytes, alignment: 4 bytes
4 print-type-size     discriminant: 1 bytes
5 print-type-size     variant `Unresumed`: 0 bytes

17 print-type-size     variant `MaybeUninit`: 4 bytes
18 print-type-size         field `.uninit`: 0 bytes
19 print-type-size         field `.value`: 4 bytes
+ print-type-size type: `std::pin::Pin<&mut {coroutine@$DIR/coroutine_discr_placement.rs:13:5: 13:7}>`: 4 bytes, alignment: 4 bytes
+ print-type-size     field `.pointer`: 4 bytes
20 print-type-size type: `std::ops::CoroutineState<(), ()>`: 1 bytes, alignment: 1 bytes
21 print-type-size     discriminant: 1 bytes
22 print-type-size     variant `Yielded`: 0 bytes

Note: some mismatched output was normalized before being compared
- print-type-size type: `std::pin::Pin<&mut {coroutine@/checkout/tests/ui/print_type_sizes/coroutine_discr_placement.rs:13:5: 13:7}>`: 4 bytes, alignment: 4 bytes
+ print-type-size type: `std::pin::Pin<&mut {coroutine@$DIR/coroutine_discr_placement.rs:13:5: 13:7}>`: 4 bytes, alignment: 4 bytes
+ print-type-size     field `.pointer`: 4 bytes


The actual stdout differed from the expected stdout
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args print_type_sizes/coroutine_discr_placement.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/print_type_sizes/coroutine_discr_placement.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/coroutine_discr_placement" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Z" "print-type-sizes" "--crate-type" "lib"
--- stdout -------------------------------
print-type-size type: `{coroutine@/checkout/tests/ui/print_type_sizes/coroutine_discr_placement.rs:13:5: 13:7}`: 8 bytes, alignment: 4 bytes
print-type-size     discriminant: 1 bytes
print-type-size     variant `Unresumed`: 0 bytes
print-type-size     variant `Suspend0`: 7 bytes
print-type-size         padding: 3 bytes
print-type-size         local `.w`: 4 bytes, alignment: 4 bytes
print-type-size     variant `Suspend1`: 7 bytes
print-type-size         padding: 3 bytes
print-type-size         local `.z`: 4 bytes, alignment: 4 bytes
print-type-size     variant `Returned`: 0 bytes
print-type-size     variant `Panicked`: 0 bytes
print-type-size type: `std::mem::ManuallyDrop<i32>`: 4 bytes, alignment: 4 bytes
print-type-size     field `.value`: 4 bytes
print-type-size type: `std::mem::MaybeUninit<i32>`: 4 bytes, alignment: 4 bytes
print-type-size     variant `MaybeUninit`: 4 bytes
print-type-size         field `.uninit`: 0 bytes
print-type-size         field `.value`: 4 bytes
print-type-size type: `std::pin::Pin<&mut {coroutine@/checkout/tests/ui/print_type_sizes/coroutine_discr_placement.rs:13:5: 13:7}>`: 4 bytes, alignment: 4 bytes
print-type-size     field `.pointer`: 4 bytes
print-type-size type: `std::ops::CoroutineState<(), ()>`: 1 bytes, alignment: 1 bytes
print-type-size     discriminant: 1 bytes
print-type-size     variant `Yielded`: 0 bytes
print-type-size         field `.0`: 0 bytes
print-type-size     variant `Complete`: 0 bytes
print-type-size         field `.0`: 0 bytes
------------------------------------------
stderr: none

---- [ui] tests/ui/print_type_sizes/coroutine_discr_placement.rs stdout end ----

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 16, 2025

Auto merge of #145477 - cjgillot:codegen-mode, r=<try>

34dd67f

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 16, 2025

cjgillot force-pushed the codegen-mode branch from a35a84a to 3f6e4db Compare August 16, 2025 14:30

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 16, 2025

Auto merge of #145477 - cjgillot:codegen-mode, r=<try>

4e9488c

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025

This comment has been minimized.

Sign in to view

cjgillot force-pushed the codegen-mode branch from 7bde1fe to bdb8bf2 Compare August 23, 2025 18:31

This comment has been minimized.

Sign in to view

cjgillot added 12 commits September 17, 2025 21:45

Introduce TypingMode::Codegen.

bf80d3c

Reuse result from eval_to_const_value_raw.

ce57409

Reuse cached layout from PostAnalysis when possible.

640e619

Do not compute coroutine layout in non-Codegen typing mode.

253c3dd

Perform KnownPanicsLint inside coroutines.

38da53f

Perform RemoveZsts inside coroutines.

0c3cca1

Perform SROA inside coroutines.

e95cf17

Allow inlining into coroutines.

959aef3

Perform jump-threading inside coroutines.

db9f50e

Return fallback size and align when static layout is error.

02eeaf9

Perform GVN inside coroutines.

cf377dc

Bless coverage.

911d2f0

cjgillot force-pushed the codegen-mode branch from bdb8bf2 to 911d2f0 Compare September 17, 2025 23:59

This comment has been minimized.

Sign in to view

Bless miri.

2f4fadc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles #145477

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles #145477

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Aug 16, 2025

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-timer commented Aug 16, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 23, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 24, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 18, 2025

Uh oh!

Uh oh!

[EXPERIMENT] Introduce TypingMode::Codegen to avoid layout cycles #145477

Are you sure you want to change the base?

[EXPERIMENT] Introduce TypingMode::Codegen to avoid layout cycles #145477

Uh oh!

Conversation

cjgillot commented Aug 16, 2025

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Aug 16, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-timer commented Aug 16, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

This comment has been minimized.

bors commented Aug 23, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 24, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 18, 2025

Uh oh!

Uh oh!

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles #145477

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles #145477